Fix 0-bootstrap iam_by_principals not taking into account all principals #2267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you provide repro, and of course this should only consider normal apply once a bootstrap SA has been created. |
ludoo
approved these changes
May 12, 2024
wiktorn
force-pushed
the
wiktorn/fast_bootstrap_iam_by_principal_fix
branch
from
a78cd30 to
71d9858
Compare
|
groups = {
gcp-billing-admins = "group:[email protected]"
gcp-devops = "group:[email protected]"
gcp-network-admins = "group:[email protected]"
gcp-organization-admins = "group:[email protected]"
gcp-security-admins = "group:[email protected]"
gcp-support = "group:[email protected]"
}
iam_by_principals = {
"group:[email protected]" = [ "roles/owner" ]
}Works, but this won't work: groups = {
gcp-billing-admins = "group:[email protected]"
gcp-devops = "group:[email protected]"
gcp-network-admins = "group:[email protected]"
gcp-organization-admins = "group:[email protected]"
gcp-security-admins = "group:[email protected]"
gcp-support = "group:[email protected]"
}
iam_by_principals = {
"group:[email protected]" = [ "roles/owner" ]
}We need to either document this limitation of |
Makes sense, good catch. |
ludoo
approved these changes
May 12, 2024
sruffilli
pushed a commit
that referenced
this pull request
May 15, 2024
…als (#2267) * Fix 0-bootstrap iam_by_principals not taking into account all principals * Add test-case for iam_by_principals for 0-bootstrap stage --------- Co-authored-by: Ludovico Magnocavallo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I provide
iam_by_principalsto bootstrap stage, not all entries are taken into account, as only principals listedlocal.iam_principalswere used. For example, if using this to grant permissions to non-FAST defined groups, this would not work.Checklist
I applicable, I acknowledge that I have:
terraform fmton all modified filestools/tfdoc.py